• kairos@programming.devOP
    link
    fedilink
    English
    arrow-up
    15
    arrow-down
    25
    ·
    1 year ago

    Unfortunately I don’t have my original patch, because I only sent that to the Linux security mailing list. I don’t think it’s a stupid thing to want to have code in the kernel, especially after spending all my time debugging this issue. The fix was trivial once I’ve pointed to the exact place where the buffer overflow happened and I should have received credit for all my effort.

    • aard@kyu.de
      link
      fedilink
      arrow-up
      34
      arrow-down
      4
      ·
      1 year ago

      You did receive credit. A good bug report allows reproducing and ideally fixing the issue - which can involve considerable effort. This is the difference between your report, and the one you linked from 6 years ago.

      Like I said, I’d probably have added an additional thanks for that in my commit message - but I’m unfamiliar with the kind of reports this particular subsystem typically receives, so it is quite possible your report is just something average coming in there.

      I personally prefer to include code suggesting a fix in my bug reports - but I usually don’t expect it to be just merged as I’m not familiar with surrounding code. I also don’t expect that to receive an additional mention - it’s just part of the report, and is often cleaner in demonstrating the issue than a problem description.

    • lysdexic@programming.dev
      link
      fedilink
      English
      arrow-up
      15
      arrow-down
      2
      ·
      1 year ago

      I don’t think it’s a stupid thing to want to have code in the kernel, especially after spending all my time debugging this issue.

      The way that you jumped straight onto broadcasting drama when your very first Linux kernel patch stumbled on the code review stage is a major red flag.

      I would hate to work with you because I would feel that I would be risking being subjected to a very public character attack each time I had to review one of your patches.

      • kairos@programming.devOP
        link
        fedilink
        English
        arrow-up
        4
        arrow-down
        5
        ·
        1 year ago

        The way that you jumped straight onto broadcasting drama

        I’m not broadcasting drama, I’m sharing my side of the story on my personal blog and distribute it to other social media platforms.

        your very first Linux kernel patch stumbled on the code review stage

        The patch didn’t stumble on the code review stage, the PowerPC maintainer didn’t want to accept patches from me and implemented his own fix.

        I would hate to work with you because I would feel that I would be risking being subjected to a very public character attack each time I had to review one of your patches.

        Why would you hate people who would describe their interactions with you? The only reason I see is that you would hate how you’ve dealt with them.

        • jet@hackertalks.com
          link
          fedilink
          English
          arrow-up
          12
          ·
          1 year ago

          I’m not broadcasting drama, I’m sharing my side of the story on my personal blog and distribute it to other social media platforms.

          That’s literally broadcasting drama.