• FlumPHP@programming.dev
    link
    fedilink
    arrow-up
    8
    ·
    1 year ago

    Code review is overrated and often poorly executed, most things should be checked automatically (review should still be done though)

    I think part of this is caused by the fact that a lot of people are bad at code reviews so they focus on things that a linter could have told you. Being able to read code isn’t necessarily the same skill as being able to write it – as evidenced by the knee jerk reaction to throw out any coffee we didn’t write ourselves.

    I still create code reviews when I’m working on a project alone because it gives me a different perspective on the changes I’ve made.

    • kaba0@programming.dev
      link
      fedilink
      arrow-up
      1
      ·
      1 year ago

      It’s not that most people are bad at it, they are just out of context.

      Like, I am completely swamped with a completely different business area of the code, besides checking for obviously dumb things, what can I really tell about a diff to a very separate part of the code which I may have never worked on before, with business requirements I don’t understand as I was not part of the 10 meetings that happened between the dev of the given ticket and BAs?