Merged

  • cornshark@lemmy.world
    link
    fedilink
    arrow-up
    5
    ·
    8 months ago

    Heh, a funny collision of terms.

    The green Merged means that the pull request was submitted into the branch.

    The DO NOT MERGE text is an instruction for automerger. Android is developed in a truly startling amount of related git branches. Automerger is the tool that propagates commits back and forth to make sure pull requests get to all flavours, versions and devices.

    DO NOT MERGE tells Automerger not to propagate that pull request to newer versions of Android, i.e. it’s a fix for the currently released version that’s not relevant to the next development version of Android for whatever reason.

    Also seen, although more rarely, is DO NOT MERGE ANYWHERE which tells Automerger not to propagate the pull request to any other branch other than where it was originally submitted, including branches for related products on the same version of Android.

    • leds@feddit.dkOP
      link
      fedilink
      arrow-up
      1
      ·
      8 months ago

      Interesting, thanks for explaining. Like someone else was saying it is already in AOSP not introduced in lineage which makes sense since it is just a cherrypick

  • aMockTie@beehaw.org
    link
    fedilink
    arrow-up
    0
    ·
    8 months ago

    Why did they submit this as a pull request in the first place? Just commit it to a WIP branch until it’s ready to merge. Am I missing something?

    • Dr. Jenkem@lemmy.blugatch.tube
      link
      fedilink
      English
      arrow-up
      1
      ·
      edit-2
      8 months ago

      It’s been a while since I’ve worked with AOSP, but I had always understood it to be some weird shit with Google’s internal processes. The “do not merge” commits are all over the AOSP, or at least they used to be.